Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom attribute support to the article spider. #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add custom attribute support to the article spider. #109

wants to merge 1 commit into from

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Dec 24, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.90%. Comparing base (3f0a47c) to head (19065d4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
zyte_spider_templates/spiders/article.py 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   95.36%   95.90%   +0.53%     
==========================================
  Files          26       26              
  Lines        2609     2610       +1     
==========================================
+ Hits         2488     2503      +15     
+ Misses        121      107      -14
Files with missing lines Coverage Δ
zyte_spider_templates/spiders/article.py 85.97% <83.33%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wRAR @Gallaecio